[DPE-2995] Receive mongos user #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Dec 5, 2023
| @@ -6,9 +6,12 @@ | |||
| This class handles the sharing of secrets between sharded components, adding shards, and removing | |||
| shards. | |||
| """ | |||
| import json | |||
There was a problem hiding this comment.
file copied from mongodb charm
| @@ -121,15 +120,6 @@ def _get_mongos_config_for_user( | |||
| tls_internal=None, # Future PR will support TLS | |||
| ) | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
moved to properties section of file
| @@ -102,11 +106,6 @@ def _install_snap_packages(self, packages: List[str]) -> None: | |||
| ) | |||
| raise | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
moved to properties section of file
| return f"mongodb://{username}:{password}@{MONGOS_SOCKET}" | ||
|
|
||
|
|
||
| async def get_secret_data(ops_test, secret_uri) -> Dict: |
There was a problem hiding this comment.
everything below here was copied from mongodb charm
dmitry-ratushnyy
previously approved these changes
Dec 6, 2023
dmitry-ratushnyy
previously approved these changes
Dec 11, 2023
juditnovak
reviewed
Dec 11, 2023
MiaAltieri
force-pushed
the
recieve-mongos-user
branch
from
6ebbf0d to
0f9cb55
Compare
juditnovak
reviewed
Dec 13, 2023
dmitry-ratushnyy
previously approved these changes
Dec 13, 2023
dmitry-ratushnyy
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt changes from MongoDB libs for
config_server_interface.pyFuture Work
Implement relation functions for host application + mongos so mongos can: