Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lib #49

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fix: update lib #49

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3e44e9
fix: update lib
Gu1nness Nov 8, 2024
1873093
chore: bump ci codecov
Gu1nness Nov 8, 2024
92351bf
fix: typo
Gu1nness Nov 8, 2024
537ab97
update libs
MiaAltieri Nov 12, 2024
39bac69
update libs
Mehdi-Bendriss Nov 12, 2024
c8e3ab5
Merge remote-tracking branch 'origin/fix/upgrade-helpers-bump-version…
Mehdi-Bendriss Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Run tests
run: tox run -e unit
- name: Upload Coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4

build:
name: Build charm | ${{ matrix.path }}
Expand Down
6 changes: 3 additions & 3 deletions lib/charms/mongos/v0/upgrade_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 3
LIBPATCH = 6

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -319,10 +319,10 @@ def pre_upgrade_check(self) -> None:
See https://chat.canonical.com/canonical/pl/cmf6uhm1rp8b7k8gkjkdsj4mya
"""
# Until the mongos charm has a config-server there is nothing to check. Allow an upgrade.
if not self.charm.mongos_initialised:
if not self._charm.mongos_initialised:
return

if not self.is_mongos_able_to_read_write():
if not self._charm.upgrade.is_mongos_able_to_read_write():
raise PrecheckFailed("mongos is not able to read/write.")


Expand Down
Loading