[DPE-4942] - add mongos charm basics pt2 - add more suggestions from Carl #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
add-basics
branch
2 times, most recently
from
7348dcd to
46ad4d1
Compare
Gu1nness
requested changes
Jul 31, 2024
Gu1nness
approved these changes
Jul 31, 2024
MiaAltieri
changed the title
| integration-test: | ||
| name: Integration test charm | 3.4.4 |
There was a problem hiding this comment.
Could we keep this? It is helpful to quickly know what juju version we're relying on, so we know when to bump
this is not DPE-5003 which is about upgrades on MongoDB VM |
Mehdi-Bendriss
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Our initial base of our charm was missing suggestions from Carl
Solution
Add those suggestions
Check libs
This will keep failing as
charms.mongos.v0.mongos_client_interfaceis not up to date, but it will be fixed as part of DPE-5005