[DPE-5039] - Simple charm ops #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gu1nness
requested changes
Aug 7, 2024
There was a problem hiding this comment.
A few general comments and remarks:
- Sorry for the amount of comments, it's just I'm reading most of this reused code for the first time.
- Overall in typing with python3.10, you can forget about
Optional[X]and move to more modern and easier to understand (and better handled)X | None - A few nits in my comments, about typos between
MongosandMongoDB. - A few comments about code that could be moved to shared libraries/python packages.
Co-authored-by: Neha Oudin <[email protected]>
Gu1nness
requested changes
Aug 7, 2024
Gu1nness
reviewed
Aug 7, 2024
Co-authored-by: Neha Oudin <[email protected]>
Gu1nness
approved these changes
Aug 7, 2024
| return | ||
|
|
||
| value = secret.get_content().get(key) | ||
| if value != Config.Secrets.SECRET_DELETED_LABEL: |
There was a problem hiding this comment.
Can you explain this? why are we testing against the string "None"?
There was a problem hiding this comment.
I actually cannot, I believe this was initially written by Judit 😅
There was a problem hiding this comment.
okay - let's please track it in a separate ticket and understand what exactly is happening there for a future PR
Co-authored-by: Mehdi Bendriss <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Mehdi-Bendriss
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Right now the mongos charm does nothing. Before even implementing relations to clients + config-server it should perform some basic operations. Namely:
Solution
Implement the above items and