[DPE-4876] Add basic charm structure #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
add-basics
branch
12 times, most recently
from
d76bbd7 to
4c27bbc
Compare
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
add-basics
branch
5 times, most recently
from
00311d2 to
262013d
Compare
MiaAltieri
force-pushed
the
add-basics
branch
4 times, most recently
from
6a46398 to
40787b5
Compare
Gu1nness
approved these changes
Jul 31, 2024
Co-authored-by: Mehdi Bendriss <[email protected]>
There was a problem hiding this comment.
(leaving review since this PR is being used as reference for our "most recent best practices")
couple other things:
- for allure, remember to add branch: https://github.com/canonical/data-platform-workflows/blob/main/.github/workflows/integration_test_charm_allure_beta.md
- remember to add to charmcraftcache-hub: https://github.com/canonical/data-platform-workflows/blob/main/.github/workflows/build_charm.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up basic structure for charms: