-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2562] POC Copy secrets from config server to shard #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
share-secrets
branch
from
September 26, 2023 09:56
12e51f6
to
bed71ce
Compare
delgod
requested changes
Sep 28, 2023
delgod
requested changes
Sep 28, 2023
dmitry-ratushnyy
previously approved these changes
Sep 28, 2023
dmitry-ratushnyy
previously approved these changes
Sep 29, 2023
delgod
approved these changes
Sep 29, 2023
dmitry-ratushnyy
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sharded components should have the same keyfile as the config server, and we want to use the same operator username/password for shards as the config server
Solution
Pass secrets to shards when they join a relation with the config server and have shards listen for this event and act appropriately
Limitations
This does not consider what happens when the user changes the password on the config server, that should be handled in a separate PR
Testing
As a POC there are not tests included in this PR. Testing was performed by hand by hand: