Bump PyYaml and ops libraries verion #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix build issue
dmitry-ratushnyy
changed the title
MiaAltieri
reviewed
Aug 21, 2023
There was a problem hiding this comment.
The conflict is caused by:
The user requested pyyaml>6.0
juju 2.9.38.1 depends on pyyaml<=6.0 and >=5.1.2
To fix this you could try to:
- loosen the range of package versions you've specified
- remove package versions to allow pip attempt to solve the dependency conflict
|
should be solved via poetry |
dmitry-ratushnyy
changed the title
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/bump_pyyaml_version
branch
from
afc91ce to
b7e5916
Compare
MiaAltieri
requested changes
Sep 5, 2023
There was a problem hiding this comment.
I believe we have the juju version hardcoded in the tests to 2.9.38.1 so I think these changes will introduce conflicts with the version of juju we are testing on, it might be necessary to bump that version
|
Closing this PR in favour of #240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Building of charm is failed with juju 3.1.5 which is installed by default with snap
PyYaml pinned to version 6.0.0 causes issues with building charm due to incompatibility with cython 3.
Solution
Bump PyYaml and ops library versions