fix: increase the timeout for charm_ha_scale integration test #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-scribner
force-pushed
the
fix-flaky-integration-tests
branch
from
1683b2d to
89de41e
Compare
|
ok so apparently a slow computer wasn't the only thing breaking this :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
during
charm_ha_scaled.py'stest_integrate, the deployment sometimes takes longer thanwait_for_idle's default 10 minutes to be up and running, resulting in integration test failures. Underpowered github runners especially contribute to this.Solution
Extend the timeout to 30 minutes.
Context
Testing Instructions
If CI passes, it works
Release Notes
Closes #71
Related to OPENG-2662