This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
add support for metrics-endpoint provider
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
requested review from
Abuelodelanada,
sed-i,
rbarry82,
PietroPasotti,
dstathis and
simskij
and removed request for
Abuelodelanada
Abuelodelanada
approved these changes
Jan 17, 2023
|
Can we just drop it entirely? Wait 10 min :D |
sed-i
reviewed
Jan 19, 2023
dstathis
reviewed
Jan 19, 2023
dstathis
approved these changes
Jan 19, 2023
|
I'm currently putting the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The Mimir charm is currently missing the
metrics-endpointprovider which would allow it to be scraped by Prometheus.Solution
Implement the relation provider in Mimir.
Testing Instructions
Deploy Mimir and Prometheus, relate them over the new interface and verify that Prometheus receives the metrics correctly.