Add Grafana Datasource support and Dashboards #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
|
This PR needs canonical/grafana-k8s-operator#295 to be resolved. |
lucabello
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
simskij
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
This contributes to #16, but doesn't close it yet.
About the dashboards, there's not really a good way for you to validate my changes. Some panels are also still gonna be empty, because Mimir doesn't always generate metrics when the feature they relate to is not used.
I've made the dashboards the best we can have at the moment; testing with partner cloud will give us an opportunity to figure out what exactly works and what doesn't, and it could give us enough insight to make more useful dashboards oureselves :)
The other library changes you see are just
charmcraft fetch-lib!