Add S3 relation to mimir coordinator #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbraAoad
requested review from
Abuelodelanada,
dstathis,
lucabello,
PietroPasotti,
sed-i and
simskij
as code owners
sed-i
reviewed
Dec 13, 2023
PietroPasotti
requested changes
Jan 2, 2024
PietroPasotti
requested changes
Jan 4, 2024
PietroPasotti
requested changes
Jan 5, 2024
There was a problem hiding this comment.
It's better to pass around typed data structures instead of untyped, opaque ones whenever possible.
You get better type hints and type checks if you pass around _S3ConfigData rather than its dictified version. I'd advise to postpone dumping it to dict until you really need the raw data structure.
To see how much this simplification helps with typing, add
reportUnknownParameterType = true
to pyproject.toml[tool.pyright] and run tox -e static-charm
(which we should put there in a different PR)
PietroPasotti
approved these changes
Jan 5, 2024
|
(and before we merge, let's make sure the integration tests are green) |
|
Integration tests are failing and are out of this PR scope, merging this PR and Integration tests will be tackled separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to integrate the Mimir cluster with external S3 Storage
Rationale
Mimir is a highly scalable, highly available solution. As such, using host path- or PVC-backed storage won’t be enough to fulfill the resilience and availability requirements when deploying a cluster with multiple units or applications.