Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #14.
Solution
This PR adds the Nginx workload to the Mimir Coordinator. Some points worth noting:
log_verbose
,resolver
,basic_auth
) are generated by functions and are supposed to be customizable (e.g., through Juju config options); at the moment those choices are hardcoded (i.e., callinglog_verbose(False)
), however it's easy to modify them in the future to expose those config options if we want to;http
scheme; this (plus certificate configurations) shall be updated when we implement TLS in the coordinatorOpen questions / future things (FIXME, TODO)
noAuthTenant
value (currently set toFIXMEnoAuthTenant
) should be taken from the Mimir configuration and passed to the Nginx object