Skip to content

Commit

Permalink
address Leon's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Abuelodelanada committed Dec 14, 2023
1 parent be384ca commit 482fd0c
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def _on_server_cert_changed(self, _):
def publish_config(self, tls: bool = False):
"""Generate config file and publish to all workers."""
mimir_config = self.coordinator.build_config(dict(self.config), tls=tls)
logger.warning(mimir_config)
self.cluster_provider.publish_configs(mimir_config)

def _on_mimir_cluster_changed(self, _):
Expand Down Expand Up @@ -200,17 +199,11 @@ def _update_cert(self):
self.server_cert.ca, # pyright: ignore
make_dirs=True,
)
# FIXME with the update-ca-certificates machinery prometheus shouldn't need
# CA_CERT_PATH.
self._nginx_container.push(
CA_CERT_PATH,
self.server_cert.ca, # pyright: ignore
make_dirs=True,
)

# Repeat for the charm container. We need it there for prometheus client requests.
ca_cert_path.parent.mkdir(exist_ok=True, parents=True)
ca_cert_path.write_text(self.server_cert.ca) # pyright: ignore
else:
self._nginx_container.remove_path(CERT_PATH, recursive=True)
self._nginx_container.remove_path(KEY_PATH, recursive=True)
Expand Down

0 comments on commit 482fd0c

Please sign in to comment.