Skip to content

Commit

Permalink
let's use mimir default values
Browse files Browse the repository at this point in the history
  • Loading branch information
Abuelodelanada committed Dec 8, 2023
1 parent 849adcf commit 0cdcbd0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions src/mimir_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ class Server(BaseModel):

http_tls_config: Dict
grpc_tls_config: Dict
tls_min_version: str
tls_cipher_suites: str


class _S3StorageBackend(BaseModel):
Expand Down
5 changes: 0 additions & 5 deletions src/mimir_coordinator.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@
"""The set of roles that need to be allocated for the
deployment to be considered robust according to the official recommendations/guidelines."""

TLS_MIN_VERSION = "VersionTLS12"
TLS_CIPHER_SUITES = "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256"


class MimirCoordinator:
"""Mimir coordinator."""
Expand Down Expand Up @@ -125,8 +122,6 @@ def build_config(self, _charm_config: Dict[str, Any], tls: bool = False) -> Dict
# todo: TLS config for memberlist
if tls:
mimir_config["server"] = {
"tls_min_version": TLS_MIN_VERSION,
"tls_cipher_suites": TLS_CIPHER_SUITES,
"http_tls_config": {
"cert": self._tls_requirer.cert,
"key": self._tls_requirer.key,
Expand Down

0 comments on commit 0cdcbd0

Please sign in to comment.