[branch-24.03] Pin LXD dependency and add check for untracked changes in dependencies. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golangci-lint snap is unfortunately not built for riscv64. The snapcraft advanced grammar [0] does unfortunately not allow us to express different build dependencies on different architectures without repetition of the list of dependencies. Making use of composition at the YAML level is also not possible because merging sequences is just not supported [1]. 0: https://snapcraft.io/docs/snapcraft-advanced-grammar 1: yaml/yaml#35 (comment) Reported-at: alexmurray/golangci-lint-snap#3 Signed-off-by: Frode Nordahl <[email protected]>
snap: Skip golangci-lint on riscv64.
The LXD Go client interface currently do not provide a versioned URL for use in Go imports. To work around this we update our update-gomod target to pin the LXD dependency using `go get`. Signed-off-by: Frode Nordahl <[email protected]>
The Launchpad build pipeline will run `go mod tidy`. Consequently a rebuild could produce a `-dirty` version string if any of our dependencies have changed. While annoying, it is actually a nice feature, because we do want to make concious choices about updates to our dependencies. Check whether a `go mod tidy` would cause go.mod to change and fail if it does. Reported-at: https://launchpad.net/bugs/2075184 Signed-off-by: Frode Nordahl <[email protected]>
|
Closing this in favor of #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review/merge commit by commit.