snap: Skip golangci-lint on riscv64. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golangci-lint snap is unfortunately not built for riscv64. The snapcraft advanced grammar [0] does unfortunately not allow us to express different build dependencies on different architectures without repetition of the list of dependencies. Making use of composition at the YAML level is also not possible because merging sequences is just not supported [1]. 0: https://snapcraft.io/docs/snapcraft-advanced-grammar 1: yaml/yaml#35 (comment) Reported-at: alexmurray/golangci-lint-snap#3 Signed-off-by: Frode Nordahl <[email protected]>
mkalcok
approved these changes
Nov 1, 2024
| @@ -274,7 +279,11 @@ parts: | |||
| export CGO_LDFLAGS_ALLOW="(-Wl,-wrap,pthread_create)|(-Wl,-z,now)" | |||
|
|
|||
| # Check that `golangci-lint` is happy with the code. | |||
| golangci-lint run --verbose | |||
| if command -v golangci-lint; then | |||
There was a problem hiding this comment.
nit: We could use more explicit condition here based on CRAFT_ARCH_BUILD_ON
There was a problem hiding this comment.
That is indeed an option, I chose not to do that as we have to declare an assertion on architecture in the build-snaps already to avoid build failure on the back of the snap not being available:
- to riscv64:
- go/1.22/stable
- else:
- go/1.22/stable
- golangci-lintWith that in mind it felt a bit too much to repeat that assertion here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golangci-lint snap is unfortunately not built for riscv64.
The snapcraft advanced grammar [0] does unfortunately not allow us to express different build dependencies on different architectures without repetition of the list of dependencies.
Making use of composition at the YAML level is also not possible because merging sequences is just not supported [1].
0: https://snapcraft.io/docs/snapcraft-advanced-grammar
1: yaml/yaml#35 (comment)
Reported-at: alexmurray/golangci-lint-snap#3
Signed-off-by: Frode Nordahl [email protected]