Cleans up containers and shims on microk8s stop and snap removal #4755
+49
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The containerd shims and the containers are now removed in both classic and strict modes when stopping microk8s (microk8s stop) or when removing the snap. Note that ctr container delete has no ``--force`` flag. Adds additional assertion in the upgrade test, ensuring that the Pods / containers have been removed on snap removal. Adds additional test, ensuring that the Pods / containers have been removed when running microk8s stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The containerd shims and the containers are now removed in both classic and strict modes when stopping microk8s (
microk8s stop) or when removing the snap.Note that
ctr container deletehas no--forceflag.Adds additional assertion in the upgrade test, ensuring that the Pods / containers have been removed on snap removal.
Adds additional test, ensuring that the Pods / containers have been removed when running
microk8s stop.Changes
The Kubernetes-related containers / Pods are now stopped when running
microk8s stop. The same containers / Pods are no longer leaked on snap removal.Testing
Added extra assertions and integration test to ensure the new behaviour.
Possible Regressions
Checklist
Notes
Inspired by: #4693
Closes: #3969