Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an api endpoint to get mon addresses #474

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

sabaini
Copy link
Collaborator

@sabaini sabaini commented Nov 22, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CleanCode (Code refactor, test updates, does not introduce functional changes)
  • Documentation update (Doc only change)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

Please describe the addition/modification of tests done to verify this change. Please also list any relevant details for your test configuration.

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm, a functional test on this API could be very beneficial (will also verify the cleanup of mon.host entries).

Signed-off-by: Peter Sabaini <[email protected]>
@sabaini sabaini changed the title WIP: Add an api endpoint to get mon addresses Add an api endpoint to get mon addresses Nov 22, 2024
Signed-off-by: Peter Sabaini <[email protected]>
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Peter Sabaini <[email protected]>
Signed-off-by: Peter Sabaini <[email protected]>
@sabaini sabaini force-pushed the feature/mon-status-api branch from 522d415 to 6bf6cf2 Compare November 22, 2024 19:10
@sabaini sabaini merged commit 332b8ce into canonical:main Nov 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants