Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve require-osd-release #460

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

sabaini
Copy link
Collaborator

@sabaini sabaini commented Nov 11, 2024

No description provided.

@sabaini sabaini force-pushed the update-osd-release-patch branch from 4913a07 to 2974bbf Compare November 11, 2024 12:31
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a nit.

Also some addtl tests

Signed-off-by: Peter Sabaini <[email protected]>
@sabaini sabaini force-pushed the update-osd-release-patch branch from 2974bbf to 607c81d Compare November 11, 2024 14:14
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmlg lmlg merged commit 98578f7 into osd-set-release Nov 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants