Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport mon.host entry cleanup from main to reef #450

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Backport mon.host entry cleanup from main to reef #450

merged 1 commit into from
Nov 12, 2024

Conversation

UtkarshBhatthere
Copy link
Contributor

Description

Adds a patch to remove mon.host entries on mon service cleanup.

Fixes #444

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

CI

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

@UtkarshBhatthere UtkarshBhatthere changed the base branch from main to reef October 24, 2024 23:18
lmlg
lmlg approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lmlg lmlg merged commit a97ae91 into canonical:reef Nov 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmlg lmlg lmlg approved these changes

@sabaini sabaini Awaiting requested review from sabaini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not join additional node to cluster
2 participants
@UtkarshBhatthere @lmlg