Added QAT configs with experimental flag. #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshBhatthere
force-pushed
the
feature/qat_enablement
branch
4 times, most recently
from
f92aff2 to
8e60795
Compare
lmlg
requested changes
Oct 15, 2024
microceph/ceph/config.go
Outdated
| @@ -222,6 +233,10 @@ func setConfigItem(c types.Config) error { | |||
| return err | |||
| } | |||
|
|
|||
| if config.Permission == ClusterConfigEXPRW { | |||
| return fmt.Errorf("WARNING: set operation on experimental config (%s)", c.Key) | |||
There was a problem hiding this comment.
I would advise against doing this. The pattern if err != nil is way too common in Go, and overloading errors for warnings seems like a footgun to me. Instead, I would simply log the warnings here instead of down below.
There was a problem hiding this comment.
It's a temporary thing, because we don't want people to run QAT on prod until we're sure about it.
There was a problem hiding this comment.
The problem with logging is that the end user will not know about it until they check the logs. An acceptable (rather better) alternative is to require --experimental flag for such configs.
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
UtkarshBhatthere
force-pushed
the
feature/qat_enablement
branch
from
8e60795 to
704dfaf
Compare
Signed-off-by: utkarsh bhatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added cluster configs for QAT enablement
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Manual Testing
Contributor's Checklist
Please check that you have: