-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build squid Microceph #345
base: main
Are you sure you want to change the base?
Conversation
3aa64d2
to
93661d5
Compare
93661d5
to
1dfd81f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the squid build works! -- think we might want to hold off before making S the default though
- name: Print logs for failure | ||
if: failure() | ||
run: | | ||
sudo snap logs microceph -n 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I wish we could reduce the duplication of those print log stanzas here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we can abstract this step out given, The actual step is a one-liner (and rest is step description in each run.).
@@ -12,7 +12,7 @@ confinement: strict | |||
|
|||
package-repositories: | |||
- type: apt | |||
cloud: bobcat | |||
cloud: caracal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we want to build for Squid by default before having a stable upstream release.
In any case we should cut a reef branch before switching master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are independent. As soon as we switch the reef track to a stable branch we can and should also build/publish the squid snap (without a stable risk level maybe).
Signed-off-by: Utkarsh Bhatt <[email protected]>
Ceph has a dependency on distutils, which was removed from the packaging since it was an undeclared package dependency. This change adds setuptools package to work around this dependency. Since distutils has been removed from python 12, this also reverts to core22. Signed-off-by: Billy Olsen <[email protected]>
RGW requires liblmbdb but this is not staged. Ensure that this is staged into the snap. Signed-off-by: Billy Olsen <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
44f97f5
to
03fdcb2
Compare
@UtkarshBhatthere think we did this now elsewhere, guess this PR could be closed? |
Description
Build MicroCeph using Ceph Squid from the Jammy-Caracal pocket
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The new build is expected to successfully comply with all existing CI tests.
Contributor's Checklist
Please check that you have: