Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build squid Microceph #345

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Build squid Microceph #345

wants to merge 5 commits into from

Conversation

UtkarshBhatthere
Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere commented Apr 29, 2024

Description

Build MicroCeph using Ceph Squid from the Jammy-Caracal pocket

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CleanCode (Code refactor, test updates, does not introduce functional changes)
  • Documentation update (Doc only change)

How Has This Been Tested?

The new build is expected to successfully comply with all existing CI tests.

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

@UtkarshBhatthere UtkarshBhatthere force-pushed the devel/squid branch 4 times, most recently from 3aa64d2 to 93661d5 Compare June 5, 2024 13:15
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the squid build works! -- think we might want to hold off before making S the default though

- name: Print logs for failure
if: failure()
run: |
sudo snap logs microceph -n 1000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I wish we could reduce the duplication of those print log stanzas here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we can abstract this step out given, The actual step is a one-liner (and rest is step description in each run.).

@@ -12,7 +12,7 @@ confinement: strict

package-repositories:
- type: apt
cloud: bobcat
cloud: caracal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to build for Squid by default before having a stable upstream release.
In any case we should cut a reef branch before switching master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are independent. As soon as we switch the reef track to a stable branch we can and should also build/publish the squid snap (without a stable risk level maybe).

UtkarshBhatthere and others added 5 commits June 26, 2024 12:25
Signed-off-by: Utkarsh Bhatt <[email protected]>
Ceph has a dependency on distutils, which was removed from the
packaging since it was an undeclared package dependency. This
change adds setuptools package to work around this dependency.

Since distutils has been removed from python 12, this also reverts
to core22.

Signed-off-by: Billy Olsen <[email protected]>
RGW requires liblmbdb but this is not staged. Ensure that this
is staged into the snap.

Signed-off-by: Billy Olsen <[email protected]>
@sabaini
Copy link
Collaborator

sabaini commented Aug 30, 2024

@UtkarshBhatthere think we did this now elsewhere, guess this PR could be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants