Adds parameters for MicroCeph bootstrap

[UtkarshBhatthere]

As a way of providing a custom public network for the mon cluster, a new bootstrap parameter is added to cli.
Desired monitor IP can be provided to the cluster bootstrap command as --mon-ip parameter.

Manual Testing ✅:

1. On bootstrap (Default MonIP: 10.5.2.241, Custom MonIP: 10.24.0.203)

ubuntu@moniptest2:~$ ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host 
       valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 8942 qdisc fq_codel state UP group default qlen 1000
    link/ether fa:16:3e:ee:a7:40 brd ff:ff:ff:ff:ff:ff
    altname enp0s3
    inet 10.5.2.241/16 metric 100 brd 10.5.255.255 scope global dynamic ens3
       valid_lft 27994sec preferred_lft 27994sec
    inet6 fe80::f816:3eff:feee:a740/64 scope link 
       valid_lft forever preferred_lft forever
4: ens8: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 8942 qdisc fq_codel state UP group default qlen 1000
    link/ether fa:16:3e:66:3e:b2 brd ff:ff:ff:ff:ff:ff
    altname enp0s8
    inet 10.24.0.203/16 metric 100 brd 10.24.255.255 scope global dynamic ens8
       valid_lft 6392sec preferred_lft 6392sec
    inet6 fe80::f816:3eff:fe66:3eb2/64 scope link 
       valid_lft forever preferred_lft forever
ubuntu@moniptest2:~$ sudo microceph cluster bootstrap --mon-ip 10.24.0.203
ubuntu@moniptest2:~$ cat /var/snap/microceph/current/conf/ceph.conf 
# # Generated by MicroCeph, DO NOT EDIT.
[global]
run dir = /var/snap/microceph/x1/run
fsid = 752d688b-1a96-4284-82b3-cf5b1fa949d1
mon host = 10.24.0.203
auth allow insecure global id reclaim = false
public addr = 10.24.0.203
public_network = 10.24.0.203/16
ms bind ipv4 = true
ms bind ipv6 = false
ubuntu@moniptest2:~$ sudo microceph.ceph mon dump
epoch 2
fsid 752d688b-1a96-4284-82b3-cf5b1fa949d1
last_changed 2023-11-01T12:15:24.111578+0000
created 2023-11-01T12:15:19.605951+0000
min_mon_release 17 (quincy)
election_strategy: 1
0: [v2:10.24.0.203:3300/0,v1:10.24.0.203:6789/0] mon.moniptest2
dumped monmap epoch 2

2. On Join

ubuntu@moniptest3:~$ cat /var/snap/microceph/current/conf/ceph.conf
# # Generated by MicroCeph, DO NOT EDIT.
[global]
run dir = /var/snap/microceph/x1/run
fsid = 752d688b-1a96-4284-82b3-cf5b1fa949d1
mon host = 10.24.0.203
auth allow insecure global id reclaim = false
public addr = 10.24.1.85
public_network = 10.24.0.203/16
ms bind ipv4 = true
ms bind ipv6 = false
ubuntu@moniptest3:~$ sudo microceph.ceph mon dump
epoch 3
fsid 752d688b-1a96-4284-82b3-cf5b1fa949d1
last_changed 2023-11-01T12:20:51.905194+0000
created 2023-11-01T12:15:19.605951+0000
min_mon_release 17 (quincy)
election_strategy: 1
0: [v2:10.24.0.203:3300/0,v1:10.24.0.203:6789/0] mon.moniptest2
1: [v2:10.24.1.85:3300/0,v1:10.24.1.85:6789/0] mon.moniptest3
dumped monmap epoch 3

[lmlg]

LGTM

[nobuto-m]

Are you folks going to implement --cluster-ip or something together with --mon-ip/--public-ip? So that we don't have to go through the post-installation steps like microceph cluster config set cluster_network 192.168.102.0/24.

[nobuto-m]

Doesn't it make more sense if we say the new option as --public-network / --cluster-network to accept a subnet instead of a bare IP address to be aligned with the Ceph config options?

ref: #197

[UtkarshBhatthere]

Doesn't it make more sense if we say the new option as --public-network / --cluster-network to accept a subnet instead of a bare IP address to be aligned with the Ceph config options?

The --mon-ip bootstrap method is consistent with popular tools like cephadm and is widely documented in upstream ceph documentation and similar resources. MicroCeph follows mon-host addressing for monitors, and, while I am sure we'll implement --public-network and --cluster-network parameters for bootstrap that would be done as a separate feature enhancement PR.
@nobuto-m

[nobuto-m]

Doesn't it make more sense if we say the new option as --public-network / --cluster-network to accept a subnet instead of a bare IP address to be aligned with the Ceph config options?

The --mon-ip bootstrap method is consistent with popular tools like cephadm and is widely documented in upstream ceph documentation and similar resources. MicroCeph follows mon-host addressing for monitors, and, while I am sure we'll implement --public-network and --cluster-network parameters for bootstrap that would be done as a separate feature enhancement PR. @nobuto-m

Makes sense. Thanks for the clarification.

[sabaini]

Hey Utkarsh,

Many thanks for that -- I've added some comments.

Would it be possible to add some testing for the multinode test case as well?

[sabaini]

Hi Utkarsh, many thanks -- think the approach with separating out bootstrapping will serve well for future feature additions

Some comments inline.

Two things will be needed in addition:

• Functional testing
• Updateing the microceph init command to work with the new approach

[UtkarshBhatthere]

Recreated PR#:#266