Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unit-test to microceph CI #224

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

UtkarshBhatthere
Copy link
Contributor

No description provided.

@UtkarshBhatthere UtkarshBhatthere force-pushed the CI/addUnitTests branch 2 times, most recently from 32ad024 to 69c3b93 Compare September 22, 2023 10:54
Copy link
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Utkarsh, thanks! One minor request inline but otherwise lgtm

fetch-depth: 0

- name: Clear FORWARD firewall rules
run: tests/scripts/actionutils.sh cleaript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but these shouldn't impede the unit tests and could be left in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, will change accordingly.

Signed-off-by: Utkarsh Bhatt <[email protected]>
@sabaini sabaini merged commit b975e5b into canonical:main Sep 26, 2023
8 checks passed
@UtkarshBhatthere UtkarshBhatthere deleted the CI/addUnitTests branch September 26, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants