Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test script for RGW S3 interface. #117

Closed

Conversation

UtkarshBhatthere
Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere commented Mar 31, 2023

Added a script for s3 IO testing on Microceph RGW.
Signed-off-by: utkarshbhatthere [email protected]

@UtkarshBhatthere UtkarshBhatthere force-pushed the s3_testscript branch 7 times, most recently from bc216db to 4b0bde1 Compare April 4, 2023 11:10
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few comments.

scripts/appS3.py Outdated Show resolved Hide resolved
scripts/appS3.py Outdated Show resolved Hide resolved
scripts/appS3.py Outdated Show resolved Hide resolved
scripts/appS3.py Outdated Show resolved Hide resolved
@UtkarshBhatthere UtkarshBhatthere requested a review from lmlg April 10, 2023 12:16
@UtkarshBhatthere UtkarshBhatthere force-pushed the s3_testscript branch 2 times, most recently from e3a7792 to a566d3d Compare April 24, 2023 10:38
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good stuff :)

Copy link
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, good stuff. I've added some minor nits and a Q
cheers!

.github/workflows/tests.yml Outdated Show resolved Hide resolved
scripts/appS3.py Outdated Show resolved Hide resolved
scripts/appS3.py Outdated Show resolved Hide resolved
@UtkarshBhatthere
Copy link
Contributor Author

Script has been moved to #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants