Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] fix: remove --containerd Kubelet cAdvisor arg. (#835) #836

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Backport] fix: remove --containerd Kubelet cAdvisor arg. (#835) #836

merged 1 commit into from
Nov 25, 2024
+0 −7

Commits on Nov 24, 2024

  1. fix: remove --containerd Kubelet cAdvisor arg. (#835) 

    This patch removes the passing of the `--containerd` argument
(value should be path to containerd socket) to `kubelet`.

This argument is actually not a kubelet argument per se, but instead it
is a cAdvisor argument (1) which was accidentally transparently declared
and shipped in kubelet a very long time ago, but had been explicitly
declared within kubelet and marked deprecated since 2017 (2).

[1] https://github.com/google/cadvisor/blob/3888dda254a8fa12f1c96be24ffdc33288ea9071/container/containerd/factory.go#L34
[2] https://github.com/kubernetes/kubernetes/pull/57613/files#diff-fecc7baa0b61f11d37dfc453aef25acca98866e1924f7765ba5592ca58fc3045R143

Signed-off-by: Nashwan Azhari <[email protected]>
    @aznashwan @bschimke95
    aznashwan authored and bschimke95 committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    2a8106a View commit details
    Browse the repository at this point in the history