Validate user provided certificates #834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
cert_validation
branch
from
54d9e7b
to
f514e7f
Compare
We'll validate user provided certificates, checking fields such as: * Common Name * Organization * NotBefore, NotAfter * DNS Subject Alternative Name Also, we ensure that the certificates are signed by the specified CAs.
petrutlucian94
force-pushed
the
cert_validation
branch
from
f514e7f
to
3d28d7c
Compare
bschimke95
approved these changes
Nov 25, 2024
| DNSSANs: []string{"kubernetes", "kubernetes.default", "kubernetes.default.svc", "kubernetes.default.svc.cluster", "kubernetes.default.svc.cluster.local"}, | ||
| } | ||
| if err := certCheck.ValidateKeypair(c.APIServerCert, c.APIServerKey); err != nil { | ||
| return fmt.Errorf("kube-apiservert certificate validation failure: %w", err) |
| @@ -142,4 +190,101 @@ func TestControlPlaneCertificates(t *testing.T) { | |||
| g.Expect(cert.DNSNames).To(ConsistOf(expectedDNSNames)) | |||
| }) | |||
| }) | |||
|
|
|||
| t.Run("InvalidSan", func(t *testing.T) { | |||
There was a problem hiding this comment.
nit: InvalidSAN according to go convention
| } | ||
| } | ||
| for _, ip := range check.IPSANs { | ||
| if err := cert.VerifyHostname("[" + ip + "]"); err != nil { |
There was a problem hiding this comment.
Is this IPv6-safe?
I guess ip cannot be [<ipv6>] so that we would have double brackets, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll validate user provided certificates, checking fields such as:
Also, we ensure that the certificates are signed by the specified CAs.