Validate ports in PreInitChecks #815
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this check happens before any of the k8s binaries are started, it's the right place to validate that the api-server, kubelet, etc. ports are available.
ktsakalozos
reviewed
Nov 22, 2024
| ports := []int{ | ||
| config.APIServer.GetSecurePort(), // kubeAPIServerPort | ||
| config.Datastore.GetK8sDqlitePort(), // k8sDqlitePort | ||
| 10248, // kubeletHealthzPort |
There was a problem hiding this comment.
All these ports can be set in the service extra args. We need to check from there for the right values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function runs before any of the k8s binaries are started, it's the right place to validate that the api-server, kubelet, etc. ports are available.
Note: containerd doesn't seem to use a consistent port, which complicates checking if it's port is available.
Note: When a port is in use, I sometimes get a
The error was: failed to POST /k8sd/cluster: Post "http://control.socket/1.0/k8sd/cluster": EOFerror before the validation happens. I'm investigating this.