Bump go-dqlite v3 and dqlite v1.17.1 LTS & deps (lxd, mc) #797
+121
−608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiseschmidtgen
force-pushed
the
KU-1965/dqlite-lts
branch
from
e510bbf
to
5838fe1
Compare
HomayoonAlimohammadi
approved these changes
Nov 14, 2024
berkayoz
reviewed
Nov 14, 2024
bschimke95
requested changes
Nov 19, 2024
There was a problem hiding this comment.
This needs to wait and be updated once canonical/microcluster#290 is released (beginning of December).
This basically means we don't need microcluster v3 anymore but can pin the v2 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump go-dqlite v3 and dqlite v1.17.1 LTS & deps (lxd, mc)
Use the new Dqlite LTS v1.17.1 and go-dqlite v3.
We are currently using microcluster v3 instead of v2 (LTS) which has a commit (that fixed the joining issues with names by enabling us to add extra sans).
Microcluster v3 skipped go-dqlite v2 and is on go-dqlite v3. Therefore, this PR uses a commit of microcluster using go-dqlite v3. Consequently, the lxd version is bumped to support the more recent commit of microcluster.