Check if Microk8s is installed #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaudetcobello
changed the title
eaudetcobello
force-pushed
the
KU-2057/check-microk8s
branch
from
27db414
to
08064e9
Compare
eaudetcobello
force-pushed
the
KU-2057/check-microk8s
branch
from
6ca2d91
to
6803416
Compare
HomayoonAlimohammadi
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Great work! Thanks @eaudetcobello! LGTM, just some minor comments and questions.
berkayoz
approved these changes
Nov 13, 2024
|
Quick question: Do we also care if people have any other thing installed that binds to the ports we care about? E.g. maybe |
Definitely, we have a card for this. |
addyess
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check that uses the snapd API to let the user know microk8s must be uninstalled.