Add timeout to integration tests LXD container removal (#757)

tests/integration/tests/test_util/harness/lxd.py

@@ -228,9 +228,17 @@ def delete_instance(self, instance_id: str):
             raise HarnessError(f"unknown instance {instance_id}")
 
         try:
-            run(["lxc", "rm", instance_id, "--force"])
+            # There are cases where the instance is not deleted properly and this command is stuck.
+            # A timeout prevents this.
+            # TODO(ben): This is a workaround for an issue that arises because of our use of
+            # privileged containers. We eventually move away from this (not supported >24.10)
+            # which should also fix this issue and make this timeout unnecessary.
+            run(["lxc", "rm", instance_id, "--force"], timeout=60 * 5)
         except subprocess.CalledProcessError as e:
             raise HarnessError(f"failed to delete instance {instance_id}") from e
+        except subprocess.TimeoutExpired:
+            LOG.warning("LXC container removal timed out.")
+            pass
 
         self.instances.discard(instance_id)