Initial version of External Certificates integration #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
mateoflorido
changed the title
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
f571351 to
139a91a
Compare
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
139a91a to
14a739b
Compare
|
/canonical/self-hosted-runners/run-workflows 14a739b |
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
1296c3a to
74237df
Compare
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
74237df to
b387b1a
Compare
addyess
reviewed
May 8, 2024
addyess
reviewed
May 8, 2024
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
656c1be to
fdbb09a
Compare
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
fdbb09a to
e7c7d29
Compare
mateoflorido
force-pushed
the
KU-417/external-certs
branch
from
a76ae26 to
d838d04
Compare
addyess
approved these changes
May 9, 2024
Comment on lines
-313
to
+307
| config (BootstrapConfig|UpdateClusterConfigRequst): | ||
| config (BootstrapConfig|UpdateClusterConfigRequest): |
Comment on lines
-173
to
+176
| app = self.applications[name] | ||
| app["charm"] = str(path.resolve()) | ||
| app["channel"] = None | ||
| # FIXME: Omit non present charms | ||
| try: | ||
| app = self.applications[name] | ||
| app["charm"] = str(path.resolve()) | ||
| app["channel"] = None | ||
| except KeyError: | ||
| log.warning("Application %s not found in bundle", name) |
There was a problem hiding this comment.
whats this for? oh? for test bundles where theres no worker charm?
There was a problem hiding this comment.
Yes, it should be there until we add support for certificates in k8s-worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec
KU083 - Vault integration
Overview
Implement the External Certificates relation using TLSCertificatesV3.
Rationale
This pull request introduces the capability of integrating the charm with external certificate providers like Vault or charms that use the TLSCertificatesV3 library, such as
self-signed-certificates.This pull request only tackles the bootstrap certificates generation. The control plane and worker certificates will be implemented in separate pull requests in the future.
Module Changes
Library Changes