Improve node removal by validating departed|broken relations #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoflorido
approved these changes
Apr 25, 2024
Comment on lines
+91
to
+93
| isinstance(event, ops.RelationDepartedEvent) | ||
| and event.relation.name in ["k8s-cluster", "cluster"] | ||
| and event.departing_unit |
There was a problem hiding this comment.
Nice use of the and operator 😄
There was a problem hiding this comment.
>>> 1 and 2 and 3 and 4
4
addyess
commented
Apr 25, 2024
Comment on lines
+598
to
+600
| if not self._is_node_ready(): | ||
| status.add(ops.WaitingStatus("Node not yet Ready")) | ||
| return |
There was a problem hiding this comment.
This is actually a nice little check for update-status to keep the node from showing "Ready" when -- actually it can't host any workloads yet because it's not Kubernetes Ready
bschimke95
approved these changes
Apr 25, 2024
| @@ -618,6 +670,39 @@ def _on_update_status(self, _event: ops.UpdateStatusEvent): | |||
| except status.ReconcilerError: | |||
| log.exception("Can't update_status") | |||
|
|
|||
| def kubectl(self, *args) -> str: | |||
There was a problem hiding this comment.
The charm file starts to get quite large. Maybe it makes sense to split it up in the future, e.g. by moving such utils into their own classes.
There was a problem hiding this comment.
it is -- and i got REALLY close to pulling the trigger on that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempts to lengthen the amount of time that a leaving node exists to give time to the lead control-plane charm time to remove the unit
Changes
k8s-clusterandclusterrelations experience a RelationDepartedEventupdate_statusevent now checks if the node itself is ready with kubectllast_gaspnow requires the node to be reported not in aReadyat least 3 times before ending the delay