Improve the juju unit status #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoflorido
requested changes
Apr 19, 2024
| relation = self.model.get_relation("cluster") | ||
| assert relation, "Missing cluster relation with k8s" # nosec | ||
| if not self.model.get_relation("cluster"): | ||
| status.add(ops.BlockedStatus("Missing cluster integration")) |
Co-authored-by: Mateo Florido <[email protected]>
addyess
commented
Apr 19, 2024
addyess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the charm reconcile loops runs the same execution steps over and over, providing meaning descriptions of those stages is important. These changes better describe the stages the charm is stepping through -- not just the early stages
Details