Support the external-cloud-provider on bootstrap of k8s #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @addyess,
We will have to update the cloud-provider in userfacingclusterconfig and bootstrap config since I merged canonical/k8s-snap#344.
Apologies, only realized I broke things here after I hit merge.
I made the updates here: #69
kwmonroe
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies the
external-cloud-providerrelation - the k8s charms can bootstrap using theexternalcloud-providerWhile this isn't enough for the other cloud-provider charms to get credentials from the cluster -- this is enough to complete half the relation and indicate that the cloud-provider is externally available.
--- Note ---
aws-cloud-providerrequires the nodes to use fqdn rather than the bare hostname in the node names. It's best in this case to just always use the fqdn when running on aws