Implement External Datastore Integration (ETCD) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 91 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 33 | 1 | 57 | 0 |
Click to see the invalid file list
- charms/worker/k8s/lib/charms/kubernetes_libs/v0/etcd.py
addyess
requested changes
Mar 19, 2024
There was a problem hiding this comment.
A few small changes and one larger concern about a potential race for whether or not to use etcd.
I think it's gonna get messy in the future when someone tries to relate etcd to an existing cluster and their data doesn't migrate. But i don't believe the charm should REQUIRE etcd.
addyess
requested changes
Mar 21, 2024
mateoflorido
force-pushed
the
KU-405/etcd
branch
from
f5e3fb5 to
2fc6161
Compare
addyess
reviewed
Mar 22, 2024
mateoflorido
force-pushed
the
KU-405/etcd
branch
3 times, most recently
from
f52a189 to
208cbf6
Compare
addyess
reviewed
Mar 22, 2024
addyess
reviewed
Mar 22, 2024
mateoflorido
force-pushed
the
KU-405/etcd
branch
from
2ad78a4 to
8a85b31
Compare
There was a problem hiding this comment.
license-eye has totally checked 92 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 34 | 1 | 57 | 0 |
Click to see the invalid file list
- test-ck-etcd.yaml
mateoflorido
force-pushed
the
KU-405/etcd
branch
2 times, most recently
from
b4e9bda to
dc3ddf2
Compare
addyess
reviewed
Mar 28, 2024
mateoflorido
force-pushed
the
KU-405/etcd
branch
from
c6c480f to
df571d2
Compare
mateoflorido
force-pushed
the
KU-405/etcd
branch
from
d1360e2 to
cc3e910
Compare
mateoflorido
force-pushed
the
KU-405/etcd
branch
from
fe74e00 to
c24d9c8
Compare
mateoflorido
force-pushed
the
KU-405/etcd
branch
from
c24d9c8 to
570c5b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement charm integration with external datastores, i.e., etcd