Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tag-prefix when promoting charms #226

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Dec 19, 2024

Overview

  • multi charm repos like this one have tags per charm and per revision. such as k8s-rev123.
  • The operator-workflows should pass this tag-prefix along during the promote job

Depends on

@addyess addyess requested a review from a team as a code owner December 19, 2024 20:10
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

Test coverage for 852a6e9

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     278     29    90%
src/charm.py                              500    260    48%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   29      2    93%
src/containerd.py                         140     22    84%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                68     24    65%
src/inspector.py                           41      4    90%
src/kube_control.py                        39     31    21%
src/literals.py                            23      0   100%
src/protocols.py                           28      5    82%
src/reschedule.py                          77      4    95%
src/snap.py                               193     29    85%
src/token_distributor.py                  181    109    40%
src/upgrade.py                            108     48    56%
-----------------------------------------------------------
TOTAL                                    1818    582    68%
coverage-report: OK (1.25=setup[1.04]+cmd[0.22] seconds)
congratulations :) (1.30 seconds)

Static code analysis report

Run started:2024-12-20 14:27:50.491580

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3864
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@addyess addyess merged commit 2391efd into main Dec 20, 2024
70 checks passed
@addyess addyess deleted the KU-2362/fix-promote-charm-job branch December 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants