-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Magic Strings with literals.py
Constants
#208
Conversation
7b8af28
to
6c836f9
Compare
6c836f9
to
3526e53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, also liked the drive by
if K8S_DQLITE_SERVICE in services and self.charm.datastore == "dqlite": | ||
if K8S_DQLITE_SERVICE in services and self.charm.datastore != "dqlite": | ||
services.remove(K8S_DQLITE_SERVICE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow yes king!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks Mateo!
Test coverage for 8ef33d2
Static code analysis report
|
Overview
Replace magic string in the codebase with constants.
Rationale
To align with the best practices from other charms and improve the code maintainability, this pull request replaces the "magic strings" used in the code with constants.