Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement
upgrade-relation
for control plane nodes #200Implement
upgrade-relation
for control plane nodes #200Changes from 1 commit
2948be7
54a7b20
a1177e9
7e7e480
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method
_announce_kubernetes_version
feels similar to the aboveget_worker_version
in some ways that it's reading the version field from thek8s-cluster
orcluster
relation.So is a version mismatch now a waiting situation because an upgrade is in-progress? Is that why there's a
NOTE
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, i see now that it's because the raising of the reconciler error prevented the upgrade events from engaging. Whew -- we still need a check to let folks know they're running on out-of-spec-version of the applications
For now
_announce_kubernetes_version
is only run on the lead CP. say you deployed and related a kw 1.35 to a 1.31 cluster. I imagine the 1.35 workers may not join. Should they join? Is the k8s-cp the right place to gripe about it? You're right that we should at least make sure we're not in an upgrade scenario before we raise the reconciler error.