-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inital pass at adding terraform for the k8s charms #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass on the templates, thank you so much for your work! I believe these should find a separate repo to live in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted from feedback
Also made some adjustments getting from the test deployment on prodstack like fixing the names of the endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @asbalderson for addressing my comments! Some more little nits and questions then we should be good to go.
Bonus points if you could add some module and functional tests. Else, we can create those later on.
@asbalderson before you push another commit here, please pull to get in sync with this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one little nit to the Readme. Confirmed things are deploying on my end as well.
Awesome work, thank you so much!
Co-authored-by: Louise K. Schmidtgen <[email protected]>
9755640
to
4c2de99
Compare
Test coverage for 4c2de99
Static code analysis report
|
Applicable spec: https://docs.google.com/document/d/1EG71A2pJ244PQRaGVzGj7Mx2B_bzE4U_OSqx4eeVI1E/edit?tab=t.0
Overview
Adds basic terraform modules for the k8s charms
Rationale
Enable deploying canonical k8s with terraform
Juju Events Changes
N/A
Module Changes
N/A
Library Changes
N/A
Checklist
src-docs
urgent
,trivial
,complex
)