Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.31] Fix dns config name (#189) #190

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

bschimke95
Copy link
Contributor

Backport of dns config bug fix: #189

@bschimke95 bschimke95 requested a review from a team as a code owner November 26, 2024 19:30
Copy link
Contributor

Test coverage for 49afc1a

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     279     29    90%
src/charm.py                              473    233    51%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   27      1    96%
src/containerd.py                         140     16    89%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                48     10    79%
src/inspector.py                           40      4    90%
src/kube_control.py                        39     31    21%
src/literals.py                             1      0   100%
src/protocols.py                           16      3    81%
src/reschedule.py                          77      4    95%
src/snap.py                               165     10    94%
src/token_distributor.py                  181    109    40%
src/upgrade.py                             31      1    97%
-----------------------------------------------------------
TOTAL                                    1630    466    71%
coverage-report: OK (1.28=setup[1.07]+cmd[0.21] seconds)
congratulations :) (1.33 seconds)

Static code analysis report

Run started:2024-11-26 19:32:19.005513

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3536
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating. Without an integration test we would never find this. The least test would be to change the config and see the config status change under the hood

@bschimke95
Copy link
Contributor Author

I added a card for us to create such a test in the next iteration.

@bschimke95 bschimke95 merged commit 13a95a3 into release-1.31 Nov 26, 2024
53 of 56 checks passed
@bschimke95 bschimke95 deleted the bschimke95/backport-fix-dns-option branch November 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants