Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused tls field #188

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

HomayoonAlimohammadi
Copy link
Contributor

Overview

This PR removes the unused default-tls-secret field from the IngressConfig (left over from this commit).

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner November 26, 2024 09:41
Copy link
Contributor

Test coverage for d7714e5

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     278     29    90%
src/charm.py                              473    233    51%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   27      1    96%
src/containerd.py                         140     16    89%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                48     10    79%
src/inspector.py                           40      4    90%
src/kube_control.py                        39     31    21%
src/literals.py                             1      0   100%
src/protocols.py                           16      3    81%
src/reschedule.py                          77      4    95%
src/snap.py                               165     10    94%
src/token_distributor.py                  181    109    40%
src/upgrade.py                             31      1    97%
-----------------------------------------------------------
TOTAL                                    1629    466    71%
coverage-report: OK (1.20=setup[0.99]+cmd[0.21] seconds)
congratulations :) (1.25 seconds)

Static code analysis report

Run started:2024-11-26 09:43:19.641781

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3534
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit 08a744d into main Nov 27, 2024
61 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the remove-tls-secret-field branch November 27, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants