-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to set extra args for kube services #184
Conversation
60e2fbf
to
8785ac6
Compare
b97012d
to
d149444
Compare
Test coverage for d149444
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 thank you @addyess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for offloading the extra_args to a new Py module.
Overview
During bootstrap, control-plane node-join, and worker node join, apply extra arguments for kube services.
Details
v=3
option set the options to--v=3
for each kube service on each unit