Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to set extra args for kube services #184

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Nov 22, 2024

Overview

During bootstrap, control-plane node-join, and worker node join, apply extra arguments for kube services.

Details

  • test that the v=3 option set the options to --v=3 for each kube service on each unit
  • ensure that joined control-planes and joined workers use the same charm config arguments

@addyess addyess requested a review from a team as a code owner November 22, 2024 19:03
@addyess addyess force-pushed the akd/service-extra-args branch from 60e2fbf to 8785ac6 Compare November 22, 2024 20:01
@addyess addyess force-pushed the akd/service-extra-args branch from b97012d to d149444 Compare November 24, 2024 19:48
Copy link
Contributor

Test coverage for d149444

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     279     29    90%
src/charm.py                              473    233    51%
src/cloud_integration.py                   80      3    96%
src/config/extra_args.py                   27      1    96%
src/containerd.py                         140     16    89%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                48     10    79%
src/inspector.py                           40      4    90%
src/kube_control.py                        39     31    21%
src/literals.py                             1      0   100%
src/protocols.py                           16      3    81%
src/reschedule.py                          77      4    95%
src/snap.py                               165     10    94%
src/token_distributor.py                  181    109    40%
src/upgrade.py                             31      1    97%
-----------------------------------------------------------
TOTAL                                    1630    466    71%
coverage-report: OK (1.22=setup[1.01]+cmd[0.20] seconds)
congratulations :) (1.27 seconds)

Static code analysis report

Run started:2024-11-24 19:50:18.564468

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3536
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Member

@ktsakalozos ktsakalozos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 thank you @addyess

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for offloading the extra_args to a new Py module.

@mateoflorido mateoflorido merged commit b0fb159 into main Nov 25, 2024
61 checks passed
@mateoflorido mateoflorido deleted the akd/service-extra-args branch November 25, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants