Add Ingress feature configuration

[HomayoonAlimohammadi]

Overview

Add ingress feature config options

Rationale

Users should be able to configure ingress feature options on the charm.

Note to reviewers

Should be rebased and merged after #175

• Just a reminder that if the default-tls-secret is not given it will be an empty string which is being used while applying ingress manifests in k8s-snap:
  • https://github.com/canonical/k8s-snap/blob/main/src/k8s/pkg/k8sd/features/contour/ingress.go#L126-L146
  • https://github.com/canonical/k8s-snap/blob/main/src/k8s/pkg/k8sd/features/cilium/ingress.go#L29-L38

[addyess]

I'd like a bit more description on this for juju administrators to have context

[addyess]

Is this a kubernetes secret? Can we clarify it's not to be confused with a juju secret? Also, is there a namespace this secret should stay in? Is it always kube-system or something else?

Suggested change

	Sets the name of the secret to be used for providing default encryption to
	ingresses.
	Sets the name of the kubernetes secret to be used for providing default encryption to
	ingresses.

[HomayoonAlimohammadi]

Thanks for pointing this out. I guess the namespace depends on the ingress being used.
For contour (in moonray impl) it's projectcontour-root: https://github.com/canonical/k8s-snap/blob/main/src/k8s/pkg/k8sd/features/contour/chart.go#L24-L29
For cilium (in default impl) it's kube-system: https://github.com/canonical/k8s-snap/blob/main/src/k8s/pkg/k8sd/features/cilium/ingress.go#L30-L38

Since I believe we're going with the default implementation which uses Cilium, it's best to say it is in the kube-system? Or maybe we can point them to a reference page about this.

[addyess]

yucky. that's sad

if this secret moves between implementations we shouldn't specify which namespace. We should be clear that's it is closely associated with the ingress implementation.

Who sets this secret by the way? Is the snap creating the secret (via the helm charm)? Why do I want to set this secret name? I'm sorry i have so many questions.

let's make sure the description here is generic enough to handle multiple implementations under the hood, but specific enough to let the juju admin know they need to administer something in the cluster.

if it's useless -- can we just drop the secret?

@bschimke95 do you have any feedback here?

[HomayoonAlimohammadi]

Thanks for the discussion Adam! I removed that option in: 90498a3

[addyess]

LGTM

[github-actions]

Test coverage for 840329d

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     270     29    89%
src/charm.py                              466    238    49%
src/cloud_integration.py                   80      3    96%
src/containerd.py                         140     16    89%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                48     10    79%
src/inspector.py                           40      3    92%
src/kube_control.py                        39     31    21%
src/literals.py                             1      0   100%
src/protocols.py                           16      3    81%
src/reschedule.py                          77      4    95%
src/snap.py                               165     10    94%
src/token_distributor.py                  181    109    40%
src/upgrade.py                             31      1    97%
-----------------------------------------------------------
TOTAL                                    1587    469    70%
coverage-report: OK (1.19=setup[0.99]+cmd[0.20] seconds)
congratulations :) (1.24 seconds)

Static code analysis report

Run started:2024-11-22 18:58:33.098161

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3422
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):