-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Load Balancer configuration through charm config #170
Conversation
This is missing the actual mapping of the options in |
Thanks, this was supposed to be a draft pr. Please ignore for now. |
4059713
to
17d8a37
Compare
8adf067
to
39d0962
Compare
39d0962
to
81d25f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions for @bschimke95 and @eaudetcobello
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 4da99af
Static code analysis report
|
closes #109 |
Overview
Note: The naming might change and is WIP for now.
Add options to the k8s charm to configure the load balancer via charm configuration.
Rationale
A user may want to overwrite the default configuration for load balancer. This should be possible both - when bootstrapping a cluster and during runtime.
Module Changes