generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a charm resource to override the installed snap #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
2 times, most recently
from
September 20, 2024 19:18
d5eced6
to
beca4c6
Compare
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
from
November 13, 2024 20:13
3f91d5b
to
36046d3
Compare
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
from
November 13, 2024 20:17
36046d3
to
ce5ed08
Compare
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
2 times, most recently
from
November 20, 2024 14:33
9576d15
to
79f3d97
Compare
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
from
November 20, 2024 14:36
79f3d97
to
b4c47fd
Compare
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
from
November 20, 2024 16:17
feeeae8
to
ac5a691
Compare
mateoflorido
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
addyess
force-pushed
the
KU-1464/support-snap-version-overrides
branch
from
November 21, 2024 15:42
9860d25
to
e317fe3
Compare
Test coverage for e317fe3
Static code analysis report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Create support to override the snap, while warning users they are using the charm in an override mode
Rationale
In order to test that new builds of the k8s snap will operate on the current stable k8s charm, we should be able to verify the snap before releasing it. To do so, we need a way to insert the snap into the charmed environment. This provides the ability to do so.