Standardise entity headers on entity detail pages #79
Conversation
|
Starting demo at: https://jaas-ai-canonical-websites-pr-79.run.demo.haus/ |
|
@barrymcgee how do I look at this? The links to charms in the demo link go to jujucharms. |
barrymcgee
force-pushed
the
charm-details-page
branch
from
4102469 to
e0966ad
Compare
|
@spencerbygraves Added QA instructions to description. |
| ) | ||
| else: | ||
| entity["user"] = entity["bundle_data"]["Meta"]["owner"]["User"] | ||
| entity["id"] = entity["bundle_data"]["Id"] |
There was a problem hiding this comment.
I'm assuming that all of the other fields already match? So the charms version of entity["id"] is already populated?
| "Info" | ||
| ] | ||
| return render_template( | ||
| "store/bundle-details.html", context={"entity": entity} |
There was a problem hiding this comment.
It's not at all clear here what data is available to the template. The only way to really find out is to run the query and log it out.
Something like https://github.com/juju/jaaslibjs/blob/master/lib/charmstore.js#L170 would clear this up here. So that every piece of data is explicitly called out.
There was a problem hiding this comment.
I'm not sure what you mean - can you make the change you suggest please and push it to this branch?
There was a problem hiding this comment.
Thanks @barrymcgee
Can you make the text inside the labels font-weight: 500; please, to be regular rather than light in weight.
Also, the heading is still displaying as 40px rather than h1.
Thanks
|
@barrymcgee thanks 👍 |
|
QA Notes: The example links now throw. |
Done
QA
View Bundle example: https://jaas-ai-canonical-websites-pr-79.run.demo.haus/u/spiculecharms/anssr-data-engine
View Charm example: https://jaas-ai-canonical-websites-pr-79.run.demo.haus/kibana
View K8s supported: https://jaas-ai-canonical-websites-pr-79.run.demo.haus/u/juju/redis-k8s