Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to core24 and python 3.12 #47

Merged
merged 16 commits into from
Jul 29, 2024
Merged

Migrate to core24 and python 3.12 #47

merged 16 commits into from
Jul 29, 2024

Conversation

upils
Copy link
Collaborator

@upils upils commented Jul 8, 2024

Migrate imagecraft to core24 to avoid relying on 2 cores (since ubuntu-image is also now using core24) and so use python3.12 in the snap.

Python3.12 is explicitly used for now because otherwise python3.10 is picked up during the build. This will need to be removed at some point.

Also add a first very basic spread test to:

  • make sure we test the snap is building and running fine
  • prepare for more tests

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (91048e5) to head (a0e7c48).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   97.60%   97.60%   -0.01%     
==========================================
  Files          20       20              
  Lines         502      500       -2     
  Branches       81       81              
==========================================
- Hits          490      488       -2     
  Misses         10       10              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@upils upils marked this pull request as draft July 8, 2024 09:24
@upils
Copy link
Collaborator Author

upils commented Jul 8, 2024

Even though every CI check is green, the build of the snap is broken. This needs to be fixed before merging.

@upils
Copy link
Collaborator Author

upils commented Jul 19, 2024

This is blocked by canonical/craft-parts#786

upils added 4 commits July 19, 2024 17:47
This is also a nice way we check the snap build in CI and are aware if it is not building properly.

Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
@upils upils requested a review from sil2100 July 22, 2024 06:32
@upils upils self-assigned this Jul 22, 2024
@upils upils marked this pull request as ready for review July 22, 2024 06:32
@upils
Copy link
Collaborator Author

upils commented Jul 22, 2024

@sil2100 2 tests are still failing because we do not have the runners setup yet. Sergio from the snapd team should set them up today or this week.

sil2100
sil2100 previously approved these changes Jul 22, 2024
Copy link
Contributor

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we want to wait with merging it until Sergio is done? Also, left some inline comments, but all might be irrelevant (just questions).

Makefile Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
snap/snapcraft.yaml Show resolved Hide resolved
@upils
Copy link
Collaborator Author

upils commented Jul 22, 2024

LGTM! Do we want to wait with merging it until Sergio is done? Also, left some inline comments, but all might be irrelevant (just questions).

Yes I would like to wait for the setup of the runners to make sure this is working fine. I copied the conf from ubuntu-image but I may have messed it up so I would like to be sure the whole thing will properly work before merging.

upils added 6 commits July 22, 2024 17:28
…t cdf5cfd

git-subtree-dir: tests/lib/external/snapd-testing-tools
git-subtree-split: cdf5cfd47b4b9d528ab4544c1d6900dec797fbf2
@upils
Copy link
Collaborator Author

upils commented Jul 23, 2024

@sil2100 I have added snapd-testing-tools as a subtree (like in ubuntu-image) so do not worry about the files added in tests/lib/external/. As previously mentioned, due to canonical/craft-parts#786, we cannot really merge this sadly because otherwise the tool will only work on 24.04.

Once we decide if we keep python3.11 or not, the code looks ready for a last review.

@upils upils requested a review from sil2100 July 23, 2024 06:30
Copy link
Contributor

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything controversial in these changes, LGTM per our discussions. Of course there's a lot, but it's all due to the snapd-testing-tools, as mentioned.

pyproject.toml Show resolved Hide resolved
@upils upils merged commit f7caf94 into main Jul 29, 2024
13 of 15 checks passed
@upils upils deleted the migrate-core24 branch July 29, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants