-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to core24 and python 3.12 #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 97.60% 97.60% -0.01%
==========================================
Files 20 20
Lines 502 500 -2
Branches 81 81
==========================================
- Hits 490 488 -2
Misses 10 10
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Even though every CI check is green, the build of the snap is broken. This needs to be fixed before merging. |
This is blocked by canonical/craft-parts#786 |
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
This is also a nice way we check the snap build in CI and are aware if it is not building properly. Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
@sil2100 2 tests are still failing because we do not have the runners setup yet. Sergio from the snapd team should set them up today or this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we want to wait with merging it until Sergio is done? Also, left some inline comments, but all might be irrelevant (just questions).
Yes I would like to wait for the setup of the runners to make sure this is working fine. I copied the conf from ubuntu-image but I may have messed it up so I would like to be sure the whole thing will properly work before merging. |
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
…t cdf5cfd git-subtree-dir: tests/lib/external/snapd-testing-tools git-subtree-split: cdf5cfd47b4b9d528ab4544c1d6900dec797fbf2
…/external/snapd-testing-tools'
Signed-off-by: Paul Mars <[email protected]>
@sil2100 I have added snapd-testing-tools as a subtree (like in ubuntu-image) so do not worry about the files added in Once we decide if we keep python3.11 or not, the code looks ready for a last review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything controversial in these changes, LGTM per our discussions. Of course there's a lot, but it's all due to the snapd-testing-tools, as mentioned.
Migrate imagecraft to core24 to avoid relying on 2 cores (since ubuntu-image is also now using core24) and so use python3.12 in the snap.
Python3.12 is explicitly used for now because otherwise python3.10 is picked up during the build. This will need to be removed at some point.
Also add a first very basic spread test to: