Re-enable pylint duplicate-code check #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
force-pushed
the
pylint-enable-duplicate-code
branch
from
0a4e44a to
abd86a3
Compare
xmkg
reviewed
Jul 29, 2024
The bulk of the changes in this patch are to the plugin_extensions that implement summary output. Most plugins have some entries in common and those are now moved to a base class so that they don't need to be redefined by each plugin. Also optimises some of the hosthelpers and checks implementations to satisfy the duplicate-code check. Some disables have been used where it was deemed that fixing the code would introduce too much instability and this can be addressed in future patches.
dosaboy
force-pushed
the
pylint-enable-duplicate-code
branch
from
abd86a3 to
a064b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.