-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some helper tools for viewing saved summaries #744
base: main
Are you sure you want to change the base?
Conversation
@nicolasbock id like to hook this up to the bash autocomplete stuff we added in |
Yes that sounds good @dosaboy . Do you want me to follow up with a PR on the bash completion scripts after you merge this one? |
ack i totally missed that one |
merged. |
tools/summary/view.py
Outdated
|
||
PLUGIN_NAMES = ['juju', 'mysql', 'openstack', 'openvswitch', 'system', | ||
'maas', 'kernel', 'kubernetes', 'rabbitmq', 'sosreport', | ||
'storage', 'vault', 'pacemaker'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing lxd.
Also, hotsos/client.py has a similar list, maybe we can just use that?
_has_potential_issues.update( | ||
s[plugin]['potential-issues']) | ||
|
||
# print("enabled: {}".format(', '.join(sorted(_enabled)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: debug?
thanks for reviews, im gonna put this back to WIP as it needs some changes |
It would be nice there was some documentation for what those scripts are doing. |
5fda435
to
875ab93
Compare
No description provided.